Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make welcome message configurable #70

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

Eliasin
Copy link
Contributor

@Eliasin Eliasin commented May 31, 2024

Hi! Just a small change that closes #49. There are some things that could maybe go back and forth like the .clone() at get_default_message to reduce .clone() at callsites not matching the rest of the config because it returns an owned string but I think the rest should be good.

I was also thinking about a PR that chooses different background images based on aspect ratio/display name (I have a 3:2 laptop screen but plug in a 16:9 monitor that I'd like a different background on), but I know that cage can mirror across two screens and I wouldn't know if that would make the feature impossible. I'm not familiar with relm4 and Wayland development in general so I'm a little fuzzy on what the behaviour would be in that case though I did spot relm4::abstractions::drawing::DrawHandler::size so that gives some hope for the possibility of dynamically detecting aspect ratio.

From what I know to add background based on name would require speaking Wayland (wl_output::name unless relm4 or the gtk bindings abstract it) so that might be a dealbreaker since it'd add a lot of complexity. Let me know what you think about either of these ideas, I recognize it might be out of scope or just plain too much work to maintain.

  • Docs Updated
  • Pre-commit hooks passing

Copy link
Owner

@rharish101 rharish101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, except for one tiny little question in the sample config file that I have noted down.

regreet.sample.toml Outdated Show resolved Hide resolved
@rharish101 rharish101 merged commit 1b3b532 into rharish101:main Jun 5, 2024
1 check passed
@rharish101
Copy link
Owner

Thanks for the PR! As for the backgrounds, that sounds like too much complexity to have different background images on different monitors. I'd recommend rather to choose a large 3:2/16:9 wallpaper and use one of the different background fits.

@Eliasin
Copy link
Contributor Author

Eliasin commented Jun 5, 2024

Thanks for the quick reply! (and oops on the config)

And thanks for the insight on the background image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override or remove "Welcome back!" message?
2 participants