Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Just a small change that closes #49. There are some things that could maybe go back and forth like the
.clone()
atget_default_message
to reduce.clone()
at callsites not matching the rest of the config because it returns an owned string but I think the rest should be good.I was also thinking about a PR that chooses different background images based on aspect ratio/display name (I have a 3:2 laptop screen but plug in a 16:9 monitor that I'd like a different background on), but I know that
cage
can mirror across two screens and I wouldn't know if that would make the feature impossible. I'm not familiar withrelm4
and Wayland development in general so I'm a little fuzzy on what the behaviour would be in that case though I did spotrelm4::abstractions::drawing::DrawHandler::size
so that gives some hope for the possibility of dynamically detecting aspect ratio.From what I know to add background based on name would require speaking Wayland (
wl_output::name
unless relm4 or the gtk bindings abstract it) so that might be a dealbreaker since it'd add a lot of complexity. Let me know what you think about either of these ideas, I recognize it might be out of scope or just plain too much work to maintain.