Automatic bootupd support #5342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladimirSlavik
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
Hello @VladimirSlavik! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: Comment last updated at 2023-11-29 15:04:09 UTC |
VladimirSlavik
added
release note required
|
@VladimirSlavik This seems to fix the issue with kickstart partitioning on multiple disks: storaged-project/blivet#1174 |
VladimirSlavik
force-pushed
the
master-bootupd-automatic
branch
from
6a311c4
to
b4076d4
Compare
VladimirSlavik
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
jkonecny12
reviewed
Nov 24, 2023
jkonecny12
approved these changes
Nov 24, 2023
VladimirSlavik
force-pushed
the
master-bootupd-automatic
branch
from
b4076d4
to
7daf79e
Compare
VladimirSlavik
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
|
This pull request will be rebased on top of #5350 to enable collection and configuration of the kernel arguments during the installation with the bootupd bootloader. See #5298 (comment) for more information. |
VladimirSlavik
force-pushed
the
master-bootupd-automatic
branch
from
7daf79e
to
6d4c4b5
Compare
VladimirSlavik
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
poncovka
approved these changes
Nov 29, 2023
poncovka
reviewed
Nov 29, 2023
Original commit message from Colin Walters was: The https://github.com/coreos/bootupd project was created to fill the gap in bootloader management for ostree-based systems. When it was created, it was just integrated into Fedora CoreOS and derivatives; this left the Atomic Desktops (Silverblue etc.) as unfixed, and it was never used by RHEL for Edge. This PR is aiming to circle back and close that gap. We detect if bootupd is in the target root; if it is, then we skip the regular bootloader work, and just run bootupd to perform the installation. The other hacks we have around the grub config are no longer necessary in this mode.
VladimirSlavik
force-pushed
the
master-bootupd-automatic
branch
from
6d4c4b5
to
af31179
Compare
VladimirSlavik
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
|
/kickstart-test --testtype bootloader |
|
I think this might be it... |
|
/kickstart-test rpm-ostree-container |
poncovka
approved these changes
Nov 30, 2023
|
Awesome, thanks! Looking forward to trying this out once there's a built ISO in rawhide/ELN. |
|
🎉 Thanks for the work! |
jkonecny12
reviewed
Dec 1, 2023
|
Nice work @poncovka and @VladimirSlavik ! |
|
Followup in #5363 |
|
Another followup item I just noticed CentOS/centos-bootc#97 which may or may not need Anaconda work, will consider |
poncovka
added a commit
to poncovka/centos-bootc
that referenced
this pull request
Dec 7, 2023
The kickstart file works with a Fedora 40+ (or ELN) installer ISO as it requires rhinstaller/anaconda#5342. Co-authored-by: Colin Walters <[email protected]>
poncovka
added a commit
to poncovka/centos-bootc
that referenced
this pull request
Dec 15, 2023
The kickstart file works with a Fedora 40+ (or ELN) installer ISO as it requires rhinstaller/anaconda#5342. Co-authored-by: Colin Walters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to work, mostly. Needs explicit partitioning in kickstart.
Replaces #5298 which has initial discussion.
TODOs: