Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace git-plugin with shell git to ensure SSL settings are respected #233

Merged

Conversation

jfilipcz
Copy link
Contributor

Change following : rht-labs/pet-battle#4

@jfilipcz jfilipcz requested review from eformat and ckavili November 10, 2022 11:17
good-1-sealed-secrets.json     good-3b-tekton.json
good-1-the-basics.json	       good-3-ubiquitous-journey.json
good-2-app-of-apps.json        good-4-extend-uj.json
good-2-argocd.json	       good-5-this-is-gitops.json directive
@eformat
Copy link
Member

eformat commented Nov 13, 2022

whilst i'm reluctant to disable TLS verification .. this is being done for a disconnected environment and packaging in the correct CA is not easily doable for all the jenkins slaves .. so i'm gonna merge it against better judgement

@eformat eformat merged commit a2be906 into rht-labs:main Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants