typingfixes

bugme.py

@@ -9,7 +9,7 @@
 import sys
 from concurrent.futures import ThreadPoolExecutor
 from urllib.parse import urlparse, parse_qs
-from typing import Any, Generator, List, Union
+from typing import Any, Dict, Generator, List, Union
 
 from datetime import datetime
 from dateutil import parser
@@ -48,7 +48,7 @@ def __init__(self, **kwargs):
 
     # Allow access this object as a dictionary
 
-    def __getitem__(self, item: str):
+    def __getitem__(self, item: str) -> Any:
         try:
             return getattr(self, item)
         except AttributeError as exc:
@@ -101,7 +101,7 @@ class Service:
     Service class to abstract methods
     """
 
-    def __init__(self, url):
+    def __init__(self, url: str):
         url = url.rstrip("/")
         self.url = url if urlparse(url).scheme else f"https://{url}"
 
@@ -169,7 +169,7 @@ def get_items(self, items: List[Item]) -> Generator[Union[Item, None], None, Non
         except BugzillaError as exc:
             logging.error("Bugzilla: %s: get_items(): %s", self.url, exc)
 
-    def _to_item(self, info) -> Union[Item, None]:
+    def _to_item(self, info: Any) -> Union[Item, None]:
         return Item(
             issue_id=info.id,
             status=info.status,
@@ -201,7 +201,7 @@ def get_item(self, item: Item) -> Union[Item, None]:
             return None
         return self._to_item(info, item)
 
-    def _to_item(self, info, item) -> Union[Item, None]:
+    def _to_item(self, info: Any, item: Item) -> Union[Item, None]:
         return Item(
             issue_id=info.number,
             status=info.state,
@@ -242,7 +242,7 @@ def get_item(self, item: Item) -> Union[Item, None]:
             return None
         return self._to_item(info, item)
 
-    def _to_item(self, info, item) -> Union[Item, None]:
+    def _to_item(self, info: Any, item: Item) -> Union[Item, None]:
         return Item(
             issue_id=info.iid,
             status=info.state,
@@ -273,7 +273,7 @@ def get_item(self, item: Item) -> Union[Item, None]:
             return None
         return self._to_item(info)
 
-    def _to_item(self, info) -> Union[Item, None]:
+    def _to_item(self, info: Any) -> Union[Item, None]:
         return Item(
             issue_id=info.id,
             status=info.status,
@@ -284,7 +284,7 @@ def _to_item(self, info) -> Union[Item, None]:
         )
 
 
-def main():
+def main() -> None:
     """
     Main function
     """
@@ -293,15 +293,17 @@ def main():
             sys.exit(f"ERROR: {CREDENTIALS_FILE} has insecure permissions")
         creds = json.load(file)
 
-    items = {}
+    items: Dict[str, List[Item]] = {}
     for arg in sys.argv[1:]:
         item = get_item(arg)
-        if item["host"] not in item:
+        if item is None:
+            continue
+        if item["host"] not in items:
             items[item["host"]] = []
         else:
             items[item["host"]].append(item)
 
-    clients = {}
+    clients: Dict[str, Any] = {}
     for host in items:
         if host == "bugzilla.suse.com":
             clients[host] = MyBugzilla(f"https://{host}", creds[host])