Skip to content

Commit

Permalink
Merge pull request #9 from ricardochaves/feature/update-pylint-260
Browse files Browse the repository at this point in the history
fixed pylint + isort
  • Loading branch information
ricardochaves authored Aug 23, 2020
2 parents a5a5a84 + 99fd81e commit 32032ec
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 48 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/all-lints.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ jobs:

steps:
- uses: actions/checkout@v1
- uses: ricardochaves/python-lint@v1.1.0
- uses: ricardochaves/python-lint@master
with:
python-root-list: "tests"
14 changes: 0 additions & 14 deletions .github/workflows/with-isort-5-lint.yml

This file was deleted.

14 changes: 0 additions & 14 deletions .github/workflows/without-isort-5-lint.yml

This file was deleted.

2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Container image that runs your code
FROM ricardobchaves6/python-lint-image:1.2.0
FROM ricardobchaves6/python-lint-image:1.3.0

# Copies your code file from your action repository to the filesystem path `/` of the container
COPY entrypoint.sh /entrypoint.sh
Expand Down
22 changes: 4 additions & 18 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,7 @@
# python-lint

## Status

<p align="left">
<a href="https://github.com/ricardochaves/python-lint"><img alt="All lints status" src="https://github.com/ricardochaves/python-lint/workflows/all-lints/badge.svg"></a></p> <p align="left">
<a href="https://github.com/ricardochaves/python-lint"><img alt="With Isort 5 status" src="https://github.com/ricardochaves/python-lint/workflows/with-isort-5-lint/badge.svg"></a></p> <p align="left">
<a href="https://github.com/ricardochaves/python-lint"><img alt="Without isort 5 status" src="https://github.com/ricardochaves/python-lint/workflows/without-isort-5-lint/badge.svg"></a></p>

> [Pylint](https://www.pylint.org/) is not compatible with [Isort 5](https://github.com/timothycrosley/isort). So if you use all enabled lints, it fails in version 1.2.0
## Limitations

You can't use Isort 5 with Pylint.

If you wanna use Pylint with isort 4 use the `v1.1.0` version.

If you wanna use Isort 5 without pylint use the version `v1.2.0` and disable pylint
<a href="https://github.com/ricardochaves/python-lint"><img alt="All lints status" src="https://github.com/ricardochaves/python-lint/workflows/all-lints/badge.svg"></a></p>

## About

Expand All @@ -37,15 +23,15 @@ Basic:
```yml
steps:
- uses: actions/checkout@v1
- uses: ricardochaves/python-lint@v1.2.0
- uses: ricardochaves/python-lint@v1.3.0
```
Options:
```yml
steps:
- uses: actions/checkout@v1
- uses: ricardochaves/python-lint@v1.2.0
- uses: ricardochaves/python-lint@v1.3.0
with:
python-root-list: "python_alelo tests"
use-pylint: false
Expand Down Expand Up @@ -73,7 +59,7 @@ flake8 $(extra-flake8-options) $(python-root-list)

black --check $(extra-black-options) $(python-root-list)

mypy $(extra-mypy-options) $(python-root-list)"
mypy $(extra-mypy-options) $(python-root-list)

isort $(extra-isort-options) $(python-root-list) -c --diff
```
Expand Down

0 comments on commit 32032ec

Please sign in to comment.