update statebuilder, fix asyncState synchronization

riccardoperra · Nov 5, 2024 · 4436bba · 4436bba
1 parent ffc54d3
commit 4436bba
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/packages/app/package.json b/packages/app/package.json
@@ -52,7 +52,7 @@
     "solid-js": "^1.9.3",
     "solid-jsx": "^1.1.4",
     "solid-mdx": "^0.0.7",
-    "statebuilder": "^0.7.2",
+    "statebuilder": "^0.7.3",
     "unique-names-generator": "^4.7.1",
     "vinxi": "^0.4.3",
     "vscode-languageserver-protocol": "^3.17.5",

diff --git a/packages/app/src/lib/statebuilder/async.ts b/packages/app/src/lib/statebuilder/async.ts
@@ -1,5 +1,5 @@
 import {AccessorWithLatest, createAsync} from '@solidjs/router';
-import {createEffect, createSignal, on, Setter} from 'solid-js';
+import {createComputed, createSignal, on, Setter} from 'solid-js';
 import {create} from 'statebuilder';
 
 export interface AsyncSignalState<T> {
@@ -32,7 +32,7 @@ function makeAsyncSignal<T>(
     options?.initialValue,
   );
 
-  createEffect(
+  createComputed(
     on(asyncState, latest => {
       // Sync latest signal retrieved by asyncState in order to be available globally after navigation
       setSignal(() => latest);
@@ -51,5 +51,6 @@ function makeAsyncSignal<T>(
  * Define an async signal.
  *
  * @experimental TODO port to statebuilder?
+ *
  */
 export const eDefineAsync = create('asyncSignal', makeAsyncSignal);
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml