Fix #16

[Seb-sti1]

This should fix #16

As Rick Lupton guessed in the issue b.item.deleted_length is non-zero when node_id is None.

{
  "CrdtGroupItem": {
    "deletedLength": 1,
    "id": "1:16",
    "left": "0:0",
    "parentId": "0:11",
    "right": "0:0"
  },
  "minVersion": 1,
  "version": 1
}

compared to the following when deletedLength == 0

{
    "CrdtGroupItem": {
        "deletedLength": 0,
        "id": "0:13",
        "left": "0:0",
        "parentId": "0:1",
        "right": "0:0",
        "value": {
            "nodeId": "0:11"
        }
    },
    "minVersion": 1,
    "version": 1
}

It fixes the parsing of my file mentioned in #32 (19 CrdtGroupItem where nodeId == None and deletedLength > 0).

@Azeirah could you test if it fixes it for you too?

[ricklupton]

Thanks for fixing this. Although they should come together, I think it would be better to check for node_id not being None, rather than checking for deleted length -- if that makes sense would you mind changing the test, and adding a line to the change log in the README?

[Azeirah]

This should fix #16

As Rick Lupton guessed in the issue b.item.deleted_length is non-zero when node_id is None.

{
  "CrdtGroupItem": {
    "deletedLength": 1,
    "id": "1:16",
    "left": "0:0",
    "parentId": "0:11",
    "right": "0:0"
  },
  "minVersion": 1,
  "version": 1
}

compared to the following when deletedLength == 0

{
    "CrdtGroupItem": {
        "deletedLength": 0,
        "id": "0:13",
        "left": "0:0",
        "parentId": "0:1",
        "right": "0:0",
        "value": {
            "nodeId": "0:11"
        }
    },
    "minVersion": 1,
    "version": 1
}

It fixes the parsing of my file mentioned in #32 (19 CrdtGroupItem where nodeId == None and deletedLength > 0).

@Azeirah could you test if it fixes it for you too?

I don't know what the original file was where the error was happening. But I have error monitoring set-up for a large amount of people using rmscene and remarks together. I am updating the service to rmscene 0.6.0 and will definitely open up a new issue if something unexpected comes up.

[Seb-sti1]

Thanks for fixing this. Although they should come together, I think it would be better to check for node_id not being None, rather than checking for deleted length -- if that makes sense would you mind changing the test, and adding a line to the change log in the README?

Done !

[ricklupton]

Thanks!