Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly add license type to Cargo.toml #39

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

BatmanAoD
Copy link
Contributor

Crates.io apparently considers this crate to have a "nonstandard" license, even though the License text is Apache-2.0. I expect this should fix that.

Crates.io apparently considers this crate to have a "nonstandard" license, even though the License text is Apache-2.0. I expect this should fix that.
@BatmanAoD
Copy link
Contributor Author

I think this fixes the issue.

cargo license output on the main branch:

Custom License File (1): rigetti-pyo3

On this branch:

apache-2.0 (1): rigetti-pyo3

Copy link
Contributor

@Shadow53 Shadow53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only potential issue I see is some future linting getting upset that we specify both license and license-file.

@BatmanAoD BatmanAoD merged commit c407d54 into main Apr 11, 2024
8 checks passed
@BatmanAoD BatmanAoD deleted the explicit-license branch April 11, 2024 21:04
@tomelliff
Copy link

LGTM. Only potential issue I see is some future linting getting upset that we specify both license and license-file.

The Cargo book says that the license-file option is only meant for non standard licenses.

If a package is using a nonstandard license, then the license-file field may be specified in lieu of the license field.

So I think we can just drop the license-file because we don't have a non standard license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants