-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for the generated documentation #53
Draft
antalsz
wants to merge
8
commits into
main
Choose a base branch
from
52-add-documentation-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jul 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a2fa204 - Browse repository at this point
Copy the full SHA a2fa204View commit details
Commits on Jul 9, 2024
-
test: move test code into a separate module
This enables easier manual testing with `cargo expand`, and will enable easier snapshot testing later.
Configuration menu - View commit details
-
Copy full SHA for f3ca274 - Browse repository at this point
Copy the full SHA f3ca274View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5710664 - Browse repository at this point
Copy the full SHA 5710664View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd220fc - Browse repository at this point
Copy the full SHA cd220fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 464b746 - Browse repository at this point
Copy the full SHA 464b746View commit details -
test: fix snapshot test of macro expansion to a specific OS
We have to specify a specific OS target because until PyO3 v0.22, PyO3 transitively depends on the [rust-ctor](https://crates.io/crates/ctor) crate, which generates different output on different OSes. Once we're doing *that*, we have to specify a specific Python ABI so that PyO3 doesn't get alarmed about cross-compilation. This is all a minor headache. One concern about this is that everyone testing locally has to run `rustup target add x864_64-unknown-linuxgnu`. CI doesn't, because I deliberately picked the triple that was running on CI, but any local development that isn't on that OS does. Is this worth it?
Configuration menu - View commit details
-
Copy full SHA for 5c2c21f - Browse repository at this point
Copy the full SHA 5c2c21fView commit details -
Configuration menu - View commit details
-
Copy full SHA for dcda90e - Browse repository at this point
Copy the full SHA dcda90eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ddd5e5 - Browse repository at this point
Copy the full SHA 5ddd5e5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.