Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #
Feature
rime_api_impl.h
uses definitions likeRIME_DEPRECATED
defined inrime_api.h
. However, it doesn't includerime_api.h
, so when opening this file editor complains.After including
rime_api.h
inrime_api_impl.h
, whereverrime_api_impl.h
is included, there is no need to includerime_api.h
, so they are removed.Unit test
Manual test
Code Review
Additional Info