Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move some headers #892

Merged
merged 1 commit into from
Jun 13, 2024
Merged

move some headers #892

merged 1 commit into from
Jun 13, 2024

Conversation

eagleoflqj
Copy link
Member

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

rime_api_impl.h uses definitions like RIME_DEPRECATED defined in rime_api.h. However, it doesn't include rime_api.h, so when opening this file editor complains.
After including rime_api.h in rime_api_impl.h, wherever rime_api_impl.h is included, there is no need to include rime_api.h, so they are removed.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@eagleoflqj eagleoflqj requested a review from ksqsf June 12, 2024 02:31
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this change can improve dev experience.

@eagleoflqj eagleoflqj merged commit 13228c2 into master Jun 13, 2024
10 checks passed
@eagleoflqj eagleoflqj deleted the header branch June 13, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants