Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unable to make install in termux, because of file system redirection #908

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix: unable to make install in termux, because of file system redirection #908

merged 1 commit into from
Jul 3, 2024

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Jul 2, 2024 •
edited
Loading

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@fxliang fxliang requested review from lotem and eagleoflqj July 2, 2024 13:56
lotem
lotem approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

说真的，代码看不懂

@fxliang
Copy link
Contributor Author

fxliang commented Jul 2, 2024

说真的，代码看不懂

在termux下，/usr是不可访问的，于是make install就会失败。相当的路径是$PREFIX， 这个就是检查当前环境$PREFIX 有/data/data/com.termux就认为是termux环境，不用/usr而用$PREFIX

eagleoflqj
eagleoflqj approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in termux by make and make install. Files are installed to /data/data/com.termux/files/usr.

@eagleoflqj eagleoflqj merged commit 3bb4fe9 into rime:master Jul 3, 2024
10 checks passed
@fxliang fxliang deleted the fix-termux branch July 3, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eagleoflqj eagleoflqj eagleoflqj approved these changes

@lotem lotem lotem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fxliang @lotem @eagleoflqj