Modules modernization #412

grob · 2020-11-03T10:40:35Z

Quite a code bomb, but no (intentional) functional changes: replaced var declarations in all standard modules with const/let, modernized code where possible. All tests pass, some tests were added.

Note that due to #411 i had to change some module imports to eg. const binary = require("binary"); and use binary.ByteArray throughout the module.

… ByteString (these are globally defined)

binary module uses defineClass to modify the global scope, so we can't (re)declare ie. const Binary

disentangled Frame and Profiler constructors: moved Frame constructor out of Profiler constructor, and pass the stack it needs as argument

…ator function

removed partition() method - this method was obviously broken and not covered by tests, so i assume it's obsolete

…eUpload() - unfolding multiline headers couldn't have worked

(now deprecated) String.prototype.toByteString() method

botic

Good someone started this 👍 I just flew over all sections, nothing in which would prevent a merge.

ArgumentsError (jsdoc rendered the constructor property)

…const variables, otherwise RingoShell class is unable to invoke them.

removed hasOwnProperty() check since Object.keys() returns only own enumerable property names

also fixes toByteString to return a ByteString, not a ByteArray

botic · 2020-12-11T17:27:35Z

@grob ready to merge, or still outstanding work from your side?

grob · 2020-12-11T17:32:09Z

No, i'm fine with that (#415 is pending too).

Robert Gaggl added 30 commits October 29, 2020 13:02

var => const/let + other modernizations

2254fd0

replaced var with const in examples

fa23f47

code modernization

088e53b

code modernization, removed obsolete require of Binary, ByteArray and…

caff111

… ByteString (these are globally defined)

code modernization, added tests for net module

88eaa88

code modernization

efbc42b

code modernization

9213031

code modernization, added test for help() method

3fdd099

code modernization

26207a8

code modernization

b0bac7e

use require instead of include in code example to make things explicit

dca4046

avoid redeclaration of consts

cc17fbd

binary module uses defineClass to modify the global scope, so we can't (re)declare ie. const Binary

modernized/simplified code, added test for Semaphore

5ca27db

code modernization

3fc56f2

code modernization (ie. var -> const/let)

f7dabd3

code modernization (ie. var -> const/let)

ae0def5

code modernization (ie. var -> const/let)

8a54199

code modernization (ie. var -> const/let)

52eb27a

code modernization

da34dbd

code modernization (ie. var -> const/let)

8f4f2c3

bugfix: arrow functions have no arguments object

27640b5

code modernization

6399f07

disentangled Frame and Profiler constructors: moved Frame constructor out of Profiler constructor, and pass the stack it needs as argument

code modernization (ie. var -> const/let)

3630d6f

code modernization (ie. var -> const/let)

305f511

code modernization (ie. var -> const/let)

24ff785

replaced include() in code example with more explicit require

f9d3aa2

code modernization (ie. var -> const/let), ZipIterator is now a Gener…

9800eb2

…ator function

added missing tests

9179851

code modernization (ie. var -> const/let)

a278580

code modernization (ie. var -> const/let)

09184bc

Robert Gaggl added 12 commits November 2, 2020 14:08

code modernization (ie. var -> const/let)

1f47930

code modernization (ie. var -> const/let)

1e92bbe

removed partition() method - this method was obviously broken and not covered by tests, so i assume it's obsolete

code modernization (ie. var -> const/let)

0362ea2

use strict comparisons and 0o1234 for octals, minor code formatting

1268b7a

code modernization (ie. var -> const/let), fixed an error in parseFil…

87f41a4

…eUpload() - unfolding multiline headers couldn't have worked

code modernization (ie. var -> const/let)

c8fde04

code modernization (ie. var -> const/let)

07046a8

code modernization (ie. var -> const/let)

fcbb093

stack traces now exclude the test module too, code modernization

d406b5f

code modernization

7d999ba

#409 implemented binary.toByteString() as replacement of the

81ed270

(now deprecated) String.prototype.toByteString() method

minor: simplified named exports

d5547a4

botic approved these changes Nov 3, 2020

View reviewed changes

Robert Gaggl added 10 commits November 3, 2020 13:19

regression fix: short option can be null/undefined

d43a229

modified prototype construction of AssertionError and

bc00d84

ArgumentsError (jsdoc rendered the constructor property)

regression fix: printResult and printError must be declared as local …

de3e2e4

…const variables, otherwise RingoShell class is unable to invoke them.

regression fix: objects.merge() must handle null/undefined arguments

556bcc7

removed hasOwnProperty() check since Object.keys() returns only own enumerable property names

fixed variable declaration

73a093a

added worker test

7b34b34

fixed write/writeln method binding

2da80dc

reverted change to arrow functions to maintain correct scope

18bb889

fixed & modernized examples

b8f35ce

#409 binary module no longer modifies the String prototype

2965bf1

also fixes toByteString to return a ByteString, not a ByteArray

botic added this to the 3.0.0 milestone Dec 11, 2020

botic added the javascript label Dec 11, 2020

botic merged commit b085a7a into ringo:master Dec 11, 2020

grob deleted the modules-modernization branch December 12, 2020 07:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modules modernization #412

Modules modernization #412

grob commented Nov 3, 2020

botic left a comment

botic commented Dec 11, 2020

grob commented Dec 11, 2020

Modules modernization #412

Modules modernization #412

Conversation

grob commented Nov 3, 2020

botic left a comment

Choose a reason for hiding this comment

botic commented Dec 11, 2020

grob commented Dec 11, 2020