-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEB3-207: add git submodule --init to methods/build.rs #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems good to me, maybe let’s wait also for @nategraf feedback before merging
I don't think the build script would make changes to the submodules. I'd be happy to have it detect and warn the user instead. |
why not @nategraf ? aren't the submodules part of the build process? |
So, my main issue is with running |
6b18056
to
6056a8a
Compare
I've added two functions to the My only dislike is that it took a lot of space in the build.rs file, which was very clean before. I could add a |
added to
methods/build.rs
:to automatically keep local libraries up to date on build.