Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second version of #52
I have a VEML6075 UV sensor hooked up to a Longan Nano, which uses 16-bit values for each register. As soon as the first 16-bit read was attempted the master was not sending ACK after the first byte. A lot of debugging later I think I found the source of the issue. In the GD32VF103 user manual (page 366) it says the following for when the number of bytes to read is 2:
The code was setting a different bit related to checksums. I have made changes according to the user manual and this example from the C GD32VF103_Firmware_Library and I'm now able to read from the sensor properly.