Fix build error that assigning to &T is undefined behavior
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chien Wong <[email protected]>
Tnze
approved these changes
Dec 26, 2023
Urgau
reviewed
Feb 14, 2024
| @@ -419,7 +420,7 @@ impl<USART: UsartX> crate::hal::serial::Write<u8> for Tx<USART> { | |||
| // NOTE(unsafe) atomic write to stateless register | |||
| // NOTE(write_volatile) 8-bit write that's not possible through the svd2rust API | |||
| unsafe { | |||
| ptr::write_volatile(&(*USART::ptr()).data as *const _ as *mut _, byte) | |||
| ptr::write_volatile(UnsafeCell::raw_get(&(*USART::ptr()).data as *const _ as _), byte); | |||
There was a problem hiding this comment.
The issue here is the creation of a reference, but creating a reference here is useless, it's not required, using the addr_of_mut! macro should create a pointer to be field without a reference:
Suggested change
| ptr::write_volatile(UnsafeCell::raw_get(&(*USART::ptr()).data as *const _ as _), byte); | |
| ptr::write_volatile(addr_of_mut!((*USART::ptr()).data), byte); |
Note that the lint is best-effort, it can be defeated, and I think that's one of the pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58