Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(toolchain): bump to nightly-2023-10-21 #12992

Merged
merged 14 commits into from
Oct 24, 2023
Merged

Conversation

TennyZhuang
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@TennyZhuang TennyZhuang requested a review from xxchan October 22, 2023 18:20
@TennyZhuang TennyZhuang requested a review from a team as a code owner October 22, 2023 18:20
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@xxchan
Copy link
Member

xxchan commented Oct 23, 2023

Shoud change no_coverage to coverage(off) rust-lang/rust#84605

Signed-off-by: TennyZhuang <[email protected]>
@TennyZhuang TennyZhuang enabled auto-merge October 23, 2023 08:51
@TennyZhuang
Copy link
Contributor Author

Currently blocked on sgodwincs/dlv-list-rs#19 (comment)

@TennyZhuang TennyZhuang force-pushed the bump-toolchain-2023-10-21 branch from 703052c to 1000000 Compare October 24, 2023 18:36
@TennyZhuang TennyZhuang added this pull request to the merge queue Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #12992 (1000000) into main (210ae71) will increase coverage by 0.06%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main   #12992      +/-   ##
==========================================
+ Coverage   68.63%   68.70%   +0.06%     
==========================================
  Files        1495     1495              
  Lines      251192   251161      -31     
==========================================
+ Hits       172401   172551     +150     
+ Misses      78791    78610     -181     
Flag Coverage Δ
rust 68.70% <16.66%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/batch/src/rpc/service/task_service.rs 0.00% <ø> (ø)
src/cmd/src/lib.rs 0.00% <ø> (ø)
src/cmd_all/src/bin/risingwave.rs 0.00% <ø> (ø)
src/common/proc_macro/src/config.rs 81.81% <ø> (ø)
src/common/proc_macro/src/lib.rs 74.50% <ø> (ø)
src/common/src/types/ordered.rs 80.95% <ø> (ø)
src/compute/src/lib.rs 17.50% <ø> (ø)
src/compute/src/rpc/service/exchange_service.rs 0.00% <ø> (ø)
src/compute/src/rpc/service/monitor_service.rs 0.00% <ø> (ø)
src/compute/src/rpc/service/stream_service.rs 0.00% <ø> (ø)
... and 27 more

... and 83 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 543bf2d Oct 24, 2023
7 of 8 checks passed
@TennyZhuang TennyZhuang deleted the bump-toolchain-2023-10-21 branch October 24, 2023 21:13
@TennyZhuang
Copy link
Contributor Author

Currently blocked on sgodwincs/dlv-list-rs#19 (comment)

Now it's here. zonyitoo/rust-ini#115 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants