Added Functionality for Adding Bounds to Burst Capture #30 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misscoded
suggested changes
Jun 24, 2019
src/actions/action-creators.test.js
Outdated
| }; | ||
| initializeCalculator(desmosMock, calcContainerMock); | ||
| return store.dispatch(actions.requestBurst(opts)).then(() => { | ||
| // slide with min/max of -3/3 should dispatch addFrame 7 times | ||
| expect(store.getActions().length).toEqual(7); | ||
| expect(store.getActions().length).toEqual(1); |
There was a problem hiding this comment.
Why is this now expected to equal to 1, rather than 7? If this has changed, the comment above doesn't match the code in place.
misscoded
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the issue outlined similarly with (#7), here we have functionality added to allow the user to specify bounds for when they are capturing a bunch of images in rapid succession using the BURST Capture functionality.
Here, I added additional functionality to allow the user to extend the bounds they've set in the settings pane to now be recognized by the BURST Capture Component. Now the Burst Component will recognize taking a series of images, just as if the user had individually pushed them using the Camera Capture component.