Settings bounds #27 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misscoded
suggested changes
Jun 24, 2019
.env
Outdated
| @@ -0,0 +1 @@ | |||
| SKIP_PREFLIGHT_CHECK=true | |||
There was a problem hiding this comment.
.env files should not be checked into the codebase. This needs to be removed.
src/components/App.test.js
Outdated
| @@ -6,6 +6,7 @@ afterEach(cleanup); | |||
|
|
|||
| describe('<App/>', () => { | |||
| it('renders without crashing', () => { | |||
| let wrapper = global.renderWithRedux(<App />); | |||
There was a problem hiding this comment.
This was commented on in your existing open PR that it should be removed.
danieljaeim
force-pushed
the
rithm-settings-bounds
branch
from
f0087d1 to
4b70862
Compare
misscoded
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to enable users to have controls over their math bounds in screenshot captures (#7 )
I started by creating additional inputs for top, bottom, left, and right bounds that correspond to the edges of the image returned from the asyncScreenshot() method.
I also added a dropdown to denote the user's choice of image setting between ('contain', 'stretch, 'preserveY', preserveX').
I then added the left, right, top, and bottom values from our inputs to our redux-store, passing them onto the Settings.js Component through the SettingsContainer. Now our settingsComponent could update and refer to our bound values from the store.
I then updated the settings action creator to account for the UPDATE_BOUNDS_SETTING, which adjusts our store's left, right, top, and bottom values as the user changes them live.
Now when we fetch an image from the API through the requestFrame() method, we also pass in an object 'mathBounds', that act as additional parameters for the async ScreenShot() method, accounting for errors such as if our left bound is greater than our right bound, or whether our bottom bound is greater than our top bound.
I finally adjusted the errors in requestFrame, to account for invalidBounds. Now when a user tries to capture the graph and send a request to the API, it validates whether the bounds follow protocol
(left bound is less than right, bottom bound is less than top), and flashes an error to the top-banner if an error occurs.
I also wrote tests for these as well, and they work in making sure our bounds are correct :)