node: Make stream sync more resilient #2412
bas-vkci.yml
on: pull_request
Common_CI
6m 19s
Client_NoEntitlements
13m 29s
Multinode
15m 33s
Client_Entitlements
17m 6s
Multinode_Ent
17m 29s
Go_Tests
4m 17s
XChain_Integration
2m 4s
Slack_Notification
4s
Annotations
18 errors and 10 warnings
|
Go_Tests
Process completed with exit code 1.
|
|
Common_CI
type syncNode is unused (U1000)
|
|
Common_CI
this result of append is never used, except maybe in other appends (SA4010)
|
|
Common_CI
ineffective break statement. Did you mean to break out of the outer loop? (SA4011)
|
|
Common_CI
ineffective break statement. Did you mean to break out of the outer loop? (SA4011)
|
|
Common_CI
redundant break statement (S1023)
|
|
Common_CI
this result of append is never used, except maybe in other appends (SA4010)
|
|
Common_CI
Process completed with exit code 1.
|
|
Common_CI:
core/node/rpc/service_sync_streams.go#L25
type `syncNode` is unused (unused)
|
|
Common_CI:
core/node/rpc/sync/client/remote.go#L148
missing cases in switch of type protocol.SyncOp: protocol.SyncOp_SYNC_UNSPECIFIED, protocol.SyncOp_SYNC_NEW, protocol.SyncOp_SYNC_CLOSE, protocol.SyncOp_SYNC_PONG (exhaustive)
|
|
Common_CI:
core/node/rpc/service_test.go#L1136
missing cases in switch of type protocol.SyncOp: protocol.SyncOp_SYNC_UNSPECIFIED, protocol.SyncOp_SYNC_PONG (exhaustive)
|
|
Common_CI:
core/node/rpc/service_test.go#L1415
missing cases in switch of type protocol.SyncOp: protocol.SyncOp_SYNC_UNSPECIFIED, protocol.SyncOp_SYNC_PONG (exhaustive)
|
|
Common_CI:
core/node/rpc/service_test.go#L1199
S1023: redundant break statement (gosimple)
|
|
Common_CI:
core/node/rpc/tester_test.go#L253
lostcancel: the nodeCancel function is not used on all paths (possible context leak) (govet)
|
|
Common_CI:
core/node/rpc/tester_test.go#L262
lostcancel: this return statement may be reached without using the nodeCancel var defined on line 253 (govet)
|
|
Common_CI:
core/node/rpc/service_test.go#L1111
SA4010: this result of append is never used, except maybe in other appends (staticcheck)
|
|
Common_CI:
core/node/rpc/service_test.go#L1391
SA4010: this result of append is never used, except maybe in other appends (staticcheck)
|
|
Common_CI
issues found
|
|
Common_CI
Explicitly mark visibility of state
|
|
Common_CI
Explicitly mark visibility of state
|
|
Common_CI
Explicitly mark visibility of state
|
|
Common_CI
Explicitly mark visibility of state
|
|
Common_CI
Explicitly mark visibility of state
|
|
Common_CI
Explicitly mark visibility of state
|
|
Common_CI
Explicitly mark visibility of state
|
|
Common_CI
Explicitly mark visibility of state
|
|
Common_CI
Explicitly mark visibility of state
|
|
Common_CI
Explicitly mark visibility of state
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
river-node-Client_Entitlements
Expired
|
74.1 KB |
|
|
river-node-Client_NoEntitlements
Expired
|
13.5 KB |
|
|
river-node-Multinode
Expired
|
115 KB |
|
|
river-node-Multinode_Ent
Expired
|
182 KB |
|