[stream-metadata] additional logging for invalid spaceAddress (#827)

river-build · Aug 20, 2024 · 70678cc · 70678cc
1 parent dd941a9
commit 70678cc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/stream-metadata/src/node.ts b/packages/stream-metadata/src/node.ts
@@ -67,11 +67,7 @@ function setupRoutes() {
 	)
 	server.get('/space/:spaceAddress/image', fetchSpaceImage)
 
-	// Generic / route to return 404
-	server.get('/', async (request, reply) => {
-		request.log.info(`GET /`)
-		return reply.code(404).send('Not found')
-	})
+	// Fastify will return 404 for any unmatched routes
 }
 
 /*

diff --git a/packages/stream-metadata/src/routes/spaceImage.ts b/packages/stream-metadata/src/routes/spaceImage.ts
@@ -12,17 +12,21 @@ export async function fetchSpaceImage(request: FastifyRequest, reply: FastifyRep
 	const { spaceAddress } = request.params as { spaceAddress?: string }
 
 	if (!spaceAddress) {
+		logger.info('spaceAddress parameter is required')
 		return reply
 			.code(400)
 			.send({ error: 'Bad Request', message: 'spaceAddress parameter is required' })
 	}
 
 	if (!isValidEthereumAddress(spaceAddress)) {
+		logger.info({ spaceAddress }, 'Invalid spaceAddress format')
 		return reply
 			.code(400)
 			.send({ error: 'Bad Request', message: 'Invalid spaceAddress format' })
 	}
 
+	logger.info({ spaceAddress }, 'Fetching space image')
+
 	let stream: StreamStateView | undefined
 	try {
 		const streamId = makeStreamId(StreamPrefix.Space, spaceAddress)