only send sync_id on new streams sync session

river-build · Jul 18, 2024 · 75105a6 · 75105a6
1 parent 67dbbeb
commit 75105a6
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/core/node/protocol/protocol.pb.go b/core/node/protocol/protocol.pb.go
diff --git a/core/node/rpc/sync/operation.go b/core/node/rpc/sync/operation.go
@@ -106,8 +106,6 @@ func (syncOp *StreamSyncOperation) Run(
 				return nil
 			}
 
-			// use the syncID as used between client and subscription node
-			msg.SyncId = syncOp.SyncID
 			if err = res.Send(msg); err != nil {
 				return err
 			}

diff --git a/protocol/protocol.proto b/protocol/protocol.proto
@@ -695,6 +695,7 @@ message SyncStreamsRequest {
 // sync session.
 message SyncStreamsResponse {
     // sync_id is the id of the sync session.
+    // only set when sync_op = SYNC_NEW or SYNC_CLOSE
     string sync_id = 1;
     // sync_op marks the type of update.
     SyncOp sync_op = 2;