Client fix for evaluating ETH balance across networks #1001
Conversation
clemire
force-pushed
the
crystal/github-838-eth-balance-across-chains-client
branch
from
1ae4073 to
de06289
Compare
…ce we plan to put such on chain anyway.
…test cases cross-network.
clemire
force-pushed
the
crystal/github-838-eth-balance-across-chains-client
branch
from
de06289 to
ede6d0e
Compare
clemire
requested review from
bas-vk,
brianathere,
pfives,
giuseppecrj and
jterzis
as code owners
|
Warning Rate limit exceeded@clemire has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 18 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe pull request introduces significant changes across multiple files, primarily focusing on the transition from native coin balance checks to Ethereum-specific balance checks. This includes renaming functions and test cases, updating logic for balance management, and implementing a new configuration structure, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
packages/web3/src/ISpaceDapp.ts (1)
211-211: Function calls need updatingThe search results indicate that there are multiple instances of
isEntitledToChannelbeing called with the old signature. Ensure all calls are updated to usexchainConfigas the parameter.
- Files to update:
packages/sdk/src/util.test.tspackages/sdk/src/channelsWithEntitlements.test.tspackages/sdk/src/sync-agent/entitlements/entitlements.tsAnalysis chain
LGTM, but verify the function usage.
The parameter update is approved.
However, ensure that this change is thoroughly tested to confirm that it behaves as expected and that all function calls to
isEntitledToChannelhave been updated to match the new signature.Run the following script to verify the function usage:
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `isEntitledToChannel` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type typescript -A 5 $'isEntitledToChannel'Length of output: 82
Script:
#!/bin/bash # Description: Verify all function calls to `isEntitledToChannel` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type ts -A 5 $'isEntitledToChannel'Length of output: 9277
clemire
deleted the
crystal/github-838-eth-balance-across-chains-client
branch
This PR involves an API change to allow harmony / other users to pass in which supported xchain ids are ether-based chains.
^^ requires a small harmony refactor.
Changes:
XChainConfigthat is extensible with future information and expresses which supported networks use ether as a network fee currency