[RIVER-1858] Node and corrupt stream metrics #1857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e period. This approach may not make sense if a stream is not replicated. Example in logs was a stream that was unavailable due to a node rebooting.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
clemire
commented
Dec 18, 2024
clemire
commented
Dec 18, 2024
clemire
commented
Dec 18, 2024
| return nil | ||
| } | ||
|
|
||
| func (a *Archiver) emitPeriodicCorruptStreamReport(ctx context.Context) { |
There was a problem hiding this comment.
the debug endpoints will not be available until Kerem gets back in the office and sets it up in AWS, so for now let's periodically print a report to logs
clemire
changed the title
…umber of failed updates.
…em to resolve when nodes are unavailable for an extended period.
…ing too many times. However it will be retried if another miniblock is observed.
clemire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1858
Consider a stream corrupt if it was unavailable for greater than 50 consecutive update attempts. The archiver rotates between nodes whenever an update fails, so in the future when replication is deployed we can reduce this number to something like 5 since at that point we will have tried every node. The 50 is in there to accomodate stream unavailability while nodes are updating.
Once a stream is corrupt, it will not attempt to retry updating itself. New miniblocks on the network will trigger the stream, however, to update itself... but it will no longer retry on failures. This is an in-memory setting and will be reset the next time the node starts.