[1894][1896][BUGFIX] - Fix replication data race when adding events, occasional test case hang when connecting to unavailable node #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d - sometimes the context would time out before making all calls to distributed nodes.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
clemire
changed the title
|
I kicked off 20 CI runs and this fix looks good. The only failure I saw was in this run, which appears to be a Blockchain-related race condition. |
|
@sergekh2 for you to consider when you get back - I'm actually not sure if the grpc connect hang is an issue in production, on mainnet / testnet? This PR only fixes it in tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1894 for a description of the first bug, #1896 for the second. The second bug seems to be exposed when the first bug is fixed, so I'm putting them in the same PR to prevent main from getting in a bad state.