Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip events, properly handle the to user address #1903

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

texuf
Copy link
Contributor

@texuf texuf commented Dec 22, 2024

The sender and receiver of the tip are the wallets that hold the space nfts, not the root wallet addresses. So we can’t assume that the receiver will have a user stream. We need to specify the to user address in the metadata and verify on appending a received transaction that this actually belongs to the user.

@texuf texuf requested a review from sergekh2 as a code owner December 22, 2024 21:53
@texuf texuf requested a review from salzbrenner December 22, 2024 21:53
Copy link

vercel bot commented Dec 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
river-sample-app ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2024 9:57pm

The sender and receiver of the tip are the wallets that hold the space nfts, not the root wallet addresses. So we can’t assume that the receiver will have a user stream. We need to specify the to user address in the metadata and verify on appending a received transaction that this actually belongs to the user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant