Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if process is defined #279

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

miguel-nascimento
Copy link
Contributor

@miguel-nascimento miguel-nascimento commented Jun 25, 2024

Now with the playground package, we're using those functions in places that doesn't even have process.env.
So we need to check if process is defined before accessing it, to avoid explosions.

Ideally, we want to remove those process.env calls in the sdk package, but that's something for other PR

@miguel-nascimento miguel-nascimento marked this pull request as ready for review June 25, 2024 21:32
@miguel-nascimento miguel-nascimento merged commit c3b30b5 into main Jun 26, 2024
8 checks passed
@miguel-nascimento miguel-nascimento deleted the miguel/check-if-has-process.env branch June 26, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants