node: add status code support to gRPC metrics #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bas-vk
force-pushed
the
basvk/grpcmetrics
branch
3 times, most recently
from
2e964d0 to
4991948
Compare
sergekh2
reviewed
Jul 17, 2024
core/node/rpc/metrics_interceptor.go
Outdated
| return next(ctx, req) | ||
| resp, err := next(ctx, req) | ||
|
|
||
| s.With(prometheus.Labels{"status": fmt.Sprintf("%d", statusCode(err))}).Inc() |
There was a problem hiding this comment.
for status, lets use text name - it's way easier to work with metrics then.
also please extract river error, if present, and use it's code, then protocol.Err_name gives you text name for the given code (works for grpc/connect codes as well).
Underlying error can be extracted by Unwrap or error.As
core/node/rpc/metrics_interceptor.go
Outdated
| unaryInflight: s.metrics.NewGaugeVecEx("grpc_unary_inflight", "gRPC unary calls in flight", "proc"), | ||
| openClientStreams: s.metrics.NewGaugeVecEx("grpc_open_client_streams", "gRPC open client streams", "proc"), | ||
| openServerStreams: s.metrics.NewGaugeVecEx("grpc_open_server_streams", "gRPC open server streams", "proc"), | ||
| rpcDuration: s.rpcDuration, |
There was a problem hiding this comment.
i'm not sure why durations is initialized this way, I think it can be removed from Service and be moved here for consistently. (also it's "method" on duration and "proc" here, lets unify)
bas-vk
force-pushed
the
basvk/grpcmetrics
branch
from
4991948 to
69db95b
Compare
sergekh2
reviewed
Jul 22, 2024
bas-vk
force-pushed
the
basvk/grpcmetrics
branch
from
69db95b to
711a2fc
Compare
sergekh2
approved these changes
Jul 23, 2024
bas-vk
force-pushed
the
basvk/grpcmetrics
branch
from
711a2fc to
d4d3c25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following metrics:
grpc_unary_status_code[proc,status], unary calls grouped by procedure and statusgrpc_server_stream_status_code[proc,status], server streams grouped by procedure and statusClient streams are more complicated to capture the status code. Since we don't those client streams metrics are not enhanced with status.