feat(contract): update SpaceOwner token URI methods
#586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new methods to manage default URI in `SpaceOwner` and `SpaceOwnerUriBase`. This includes setting and getting the default URI, updating the `_render` method to use the default URI, and adding relevant events and validation checks.
Simplify layout access in `SpaceOwner` with direct getter and setter methods. Add selectors for `setDefaultUri` and `getDefaultUri` in deployment script. Extend tests to cover new `setDefaultUri` functionality and improve `tokenURI` tests.
shuhuiluo
requested review from
sergekh2,
giuseppecrj,
pfives,
brianathere and
jterzis
as code owners
brianathere
reviewed
Jul 31, 2024
| if (spaceAddress == address(0)) revert SpaceOwner__SpaceNotFound(); | ||
|
|
||
| SpaceOwnerStorage.Space storage space = ds.spaceByAddress[spaceAddress]; | ||
| string memory uri = bytes(space.uri).length == 0 |
There was a problem hiding this comment.
I believe if the space sets the URI, we don't want to append the spaceAddress to it, we only want it when we're sending the default URI back.
There was a problem hiding this comment.
@tak-hntlabs Could you confirm and update the Linear issue accordingly?
There was a problem hiding this comment.
yes, Brian is right. If the caller sets it explicitly, we should respect that, and not add any thing else to the returned uri. I'll update the Linear.
giuseppecrj
approved these changes
Jul 31, 2024
tak-hntlabs
reviewed
Jul 31, 2024
Streamline the logic for building URIs by prioritizing space URIs and falling back to the default URI. The test suite has been updated to reflect these changes, ensuring that URIs with and without trailing slashes are handled correctly.
Added Solady library to the project and updated `remappings.txt` and `copyLibs.js` accordingly. Replaced OpenZeppelin's `Strings` with Solady's `LibString` for string operations in `SpaceOwnerUriBase.sol` and corresponding test file. Updated `package.json` and `yarn.lock` to include Solady.
tak-hntlabs
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new methods to manage default URI in
SpaceOwnerandSpaceOwnerUriBase. This includes setting and getting the default URI, updating the_rendermethod to use the default URI, and adding relevant events and validation checks.Simplify layout access in
SpaceOwnerwith direct getter and setter methods. Add selectors forsetDefaultUriandgetDefaultUriin deployment script. Extend tests to cover newsetDefaultUrifunctionality and improvetokenURItests.Streamline the logic for building URIs by prioritizing space URIs and falling back to the default URI. The test suite has been updated to reflect these changes, ensuring that URIs with and without trailing slashes are handled correctly.
Added Solady library to the project and updated
remappings.txtandcopyLibs.jsaccordingly. Replaced OpenZeppelin'sStringswith Solady'sLibStringfor string operations inSpaceOwnerUriBase.soland corresponding test file. Updatedpackage.jsonandyarn.lockto include Solady.https://linear.app/hnt-labs/issue/HNT-10522/space-metadata-uri
https://linear.app/hnt-labs/issue/HNT-10623/spec-town-metadata-changes-to-support-public-town-image