weezerpedia function call #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hh2010
commented
Nov 12, 2024
bot/scripts/wiki_to_markdown.py
Outdated
| @@ -50,6 +50,9 @@ def wiki_to_markdown(text, wiki_url_prefix='https://www.weezerpedia.com/wiki/'): | |||
| # Trim any leading or trailing whitespaces | |||
| text = text.strip() | |||
|
|
|||
| url_pattern = r'http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\\(\\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+' | |||
There was a problem hiding this comment.
the URLs just take up character limit and dont add value to response since gpt cannot traverse them
so i add a param to remove them when used for gpt function call
|
@riverscuomo should be good for review, lmk if any thoughts |
riverscuomo
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #7
tested locally and it works. checked that slash command still works as well.
however im noticing that sometimes it fails to query for "make believe" during my testing. not sure why but can just keep an eye on it and see if its something to improve on.