Add new interface for adjust rz reg contents in some cases #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVilka
requested changes
Jun 29, 2023
| std::string r = tracereg; | ||
| std::transform(r.begin(), r.end(), r.begin(), ::tolower); | ||
|
|
||
| if (r.at(0) == 's') { |
There was a problem hiding this comment.
I suggest to put the the comment from the PR description here, right in the code, otherwise it would be hard to understand why it's needed
thestr4ng3r
reviewed
Jun 29, 2023
| @@ -192,7 +193,8 @@ FrameCheckResult RizinEmulator::RunFrame(ut64 index, frame *f, std::optional<ut6 | |||
| continue; | |||
| } | |||
| RzBitVector *bv = rz_bv_new_from_bytes_le((const ut8 *)o.value().data(), 0, RegOperandSizeBits(o)); | |||
| adapter->AdjustRegContentsFromTrace(ro.name(), bv); | |||
| RzBitVector *extra = rz_reg_get_bv(reg.get(), ri); | |||
There was a problem hiding this comment.
I don't think it is a good idea to read register contents here. They might be undefined depending on what happened before.
Rot127
approved these changes
Jun 29, 2023
|
What is the resolution with this? One year has passed. |
|
@Heersin Is it still needed? If not I would vote for closing so less changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BAP-qemu frame represent register D17 as two S registers(S34, S35), while those S registers(S32/S33 ...) are not existed in rz_reg for arm32.
dnregister can be represented asconcat(S_2n, S_2n+1), to get the correct d register value I need both two S register value in the for-loop of rz-tracetetCurrently my solution is to modify Adapter interface to support it. It will affect other architecture's adapters, I am not sure it's a best practice.