Update S1G beacon parsing based on code review. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Includes unit test parsing and confirming an S1G beacon - Includes support for the new Frame Control format for type=3, subtype=1 (S1G beacon) - Includes changes to support addressing used in S1G beacon. All dot11 unit tests pass with this change.
- Use set for 'type in' checks for extension frame type 3, subtype 1 (S1G beacon).
beacon frame control field). This allows use of BitField for the 'bw', and FlagsField for the remaining bits.
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 80.77% 80.77%
=======================================
Files 355 355
Lines 84709 84709
=======================================
Hits 68425 68425
Misses 16284 16284
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the change for parsing S1G beacon frames:
Fixes secdev#4439