-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and update code #33
base: master
Are you sure you want to change the base?
Conversation
bluddy
commented
Jan 22, 2020
- Update to work with decompress 1.0.0
- Tested by reading and writing the same PNG file.
- Simplified: since we already have an input/output abstraction, there's no need to functorize the PNG writer. Make it symmetric with reader.
- Fix bug in writer: close wasn't being called on the channel, leading to 0 size output files.
Make writer symmetric with reader. Get rid of unnecessary functorization (we already abstract with chunk reader/writer)
(Would be great to provide as option for high performance)
Can I have some feedback on this PR? |
I believe these are already covered by my gigantic unmerged GIF PR (perhaps modulo the write) which also changes various abstractions in order to support animated GIFs / progressive rendering, and that is why I don't feel like merging this since it'd be a painful rebase. I don't know how @rlepigre feels, and to be clear I'm not opposing this PR, just don't feel motivated to deal with it myself. :( |
@rlepigre & @bluddy: How would you two feel about if I:
|
Sounds good to me! Thanks! |
I haven't forgotten about this, having trouble upgrading to |
As a big fan of the |