fix

Signed-off-by: Ryan Leung <[email protected]>
rleungx · Dec 26, 2024 · 9b34b99 · 9b34b99
1 parent 0f13444
commit 9b34b99
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/client/pkg/utils/grpcutil/grpcutil.go b/client/pkg/utils/grpcutil/grpcutil.go
@@ -74,6 +74,7 @@ func UnaryBackofferInterceptor() grpc.UnaryClientInterceptor {
 	}
 }
 
+// UnaryCircuitBreakerInterceptor is a gRPC interceptor that adds a circuit breaker to the call.
 func UnaryCircuitBreakerInterceptor() grpc.UnaryClientInterceptor {
 	return func(ctx context.Context, method string, req, reply any, cc *grpc.ClientConn, invoker grpc.UnaryInvoker, opts ...grpc.CallOption) error {
 		cb := circuitbreaker.FromContext(ctx)

diff --git a/tests/integrations/client/client_test.go b/tests/integrations/client/client_test.go
@@ -2073,7 +2073,7 @@ func TestCircuitBreaker(t *testing.T) {
 	cli := setupCli(ctx, re, endpoints)
 	defer cli.Close()
 
-	circuitBreaker := cb.NewCircuitBreaker[*pdpb.GetRegionResponse]("region_meta", circuitBreakerSettings)
+	circuitBreaker := cb.NewCircuitBreaker("region_meta", circuitBreakerSettings)
 	ctx = cb.WithCircuitBreaker(ctx, circuitBreaker)
 	for range 10 {
 		region, err := cli.GetRegion(ctx, []byte("a"))
@@ -2128,7 +2128,7 @@ func TestCircuitBreakerOpenAndChangeSettings(t *testing.T) {
 	cli := setupCli(ctx, re, endpoints)
 	defer cli.Close()
 
-	circuitBreaker := cb.NewCircuitBreaker[*pdpb.GetRegionResponse]("region_meta", circuitBreakerSettings)
+	circuitBreaker := cb.NewCircuitBreaker("region_meta", circuitBreakerSettings)
 	ctx = cb.WithCircuitBreaker(ctx, circuitBreaker)
 	for range 10 {
 		region, err := cli.GetRegion(ctx, []byte("a"))
@@ -2178,7 +2178,7 @@ func TestCircuitBreakerHalfOpenAndChangeSettings(t *testing.T) {
 	cli := setupCli(ctx, re, endpoints)
 	defer cli.Close()
 
-	circuitBreaker := cb.NewCircuitBreaker[*pdpb.GetRegionResponse]("region_meta", circuitBreakerSettings)
+	circuitBreaker := cb.NewCircuitBreaker("region_meta", circuitBreakerSettings)
 	ctx = cb.WithCircuitBreaker(ctx, circuitBreaker)
 	for range 10 {
 		region, err := cli.GetRegion(ctx, []byte("a"))