-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix path issues in v1.9.1 #172
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will wait to double check before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect ⭐
I updated the PR because of the prev commit was reverted (This PR includes those changes). BTW, I think the original commit adds a feature, so instead releasing it as |
Any news guys? I'm on Laravel 9 and I had to change the file directly to support the /lang folder instead of /resources/lang |
I apologize for the slow response. Will chech that today. |
Hi @rmariuzzo, any idea when this fix will be released? This issue is still causing many headaches for people using Laravel 9, and Laravel 10 is around the corner... |
@jonaszkadziela I recall we fixed the issue the day it was discovered by reverting breaking changes; update your dependency to the newest version (1.9.0) and you should be good to go. |
Looking at the Therefore, any fresh Laravel 9.x application or existing project that uses the new path does not work with this package. Running So, unfortunately, version 1.9.0 is not working. If this PR is merged, the issue should be resolved. |
I'm gonna take a look at this today, in a couple of hours. |
Guys, is this fix released? |
Fixes for the paths in v1.9.1