Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Updating to 1.18.2 #2

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

Skywalker8510
Copy link

Iv done a bit of work to get this working on 1.18.2 but i dont know what to do to fix the mixins. im going to continue trying to figure this out but if anyone can help that would be great.

@Skywalker8510
Copy link
Author

At this point I don't know what to do anymore but this is the error I'm getting when I launch Minecraft. if anyone can help me understand this that would be great

Prism Launcher version: 7.2 (official)

Launched instance in online mode

authserver.mojang.com resolves to:
[108.157.150.53, 108.157.150.57, 108.157.150.99, 108.157.150.106]

session.minecraft.net resolves to:
[13.107.213.38, 13.107.246.38]

textures.minecraft.net resolves to:
[13.107.213.38, 13.107.246.38]

api.mojang.com resolves to:
[13.107.213.38, 13.107.246.38]

Minecraft folder is:
C:/Users/skywa/AppData/Roaming/PrismLauncher/instances/1.18.2/.minecraft

Java path is:
C:/Program Files/Common Files/Oracle/Java/javapath/javaw.exe

Java is version 17.0.8, using 64 (amd64) architecture, from Oracle Corporation.

Main Class:
net.fabricmc.loader.impl.launch.knot.KnotClient

Native path:
C:/Users/skywa/AppData/Roaming/PrismLauncher/instances/1.18.2/natives

Traits:
traits XR:Initial
traits FirstThreadOnMacOS

Libraries:
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl-glfw/3.2.2/lwjgl-glfw-3.2.2.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl-jemalloc/3.2.2/lwjgl-jemalloc-3.2.2.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl-openal/3.2.2/lwjgl-openal-3.2.2.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl-opengl/3.2.2/lwjgl-opengl-3.2.2.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl-stb/3.2.2/lwjgl-stb-3.2.2.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl/3.2.2/lwjgl-3.2.2.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl-tinyfd/3.2.2/lwjgl-tinyfd-3.2.2.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/mojang/logging/1.0.0/logging-1.0.0.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/mojang/blocklist/1.0.10/blocklist-1.0.10.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/mojang/patchy/2.2.10/patchy-2.2.10.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/github/oshi/oshi-core/5.8.5/oshi-core-5.8.5.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/net/java/dev/jna/jna/5.10.0/jna-5.10.0.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/net/java/dev/jna/jna-platform/5.10.0/jna-platform-5.10.0.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/slf4j/slf4j-api/1.8.0-beta4/slf4j-api-1.8.0-beta4.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/apache/logging/log4j/log4j-slf4j18-impl/2.17.1/log4j-slf4j18-impl-2.17.1.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/ibm/icu/icu4j/70.1/icu4j-70.1.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/mojang/javabridge/1.2.24/javabridge-1.2.24.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/net/sf/jopt-simple/jopt-simple/5.0.4/jopt-simple-5.0.4.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/io/netty/netty-all/4.1.68.Final/netty-all-4.1.68.Final.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/google/guava/guava/31.0.1-jre/guava-31.0.1-jre.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/apache/commons/commons-lang3/3.12.0/commons-lang3-3.12.0.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/commons-io/commons-io/2.11.0/commons-io-2.11.0.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/commons-codec/commons-codec/1.15/commons-codec-1.15.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/mojang/brigadier/1.0.18/brigadier-1.0.18.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/mojang/datafixerupper/4.1.27/datafixerupper-4.1.27.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/google/code/gson/gson/2.8.9/gson-2.8.9.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/mojang/authlib/3.3.39/authlib-3.3.39.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/apache/commons/commons-compress/1.21/commons-compress-1.21.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/apache/httpcomponents/httpclient/4.5.13/httpclient-4.5.13.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/commons-logging/commons-logging/1.2/commons-logging-1.2.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/apache/httpcomponents/httpcore/4.4.14/httpcore-4.4.14.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/it/unimi/dsi/fastutil/8.5.6/fastutil-8.5.6.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/apache/logging/log4j/log4j-api/2.17.1/log4j-api-2.17.1.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/apache/logging/log4j/log4j-core/2.17.1/log4j-core-2.17.1.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/mojang/text2speech/1.12.4/text2speech-1.12.4.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/net/fabricmc/intermediary/1.18.2/intermediary-1.18.2.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/net/fabricmc/tiny-mappings-parser/0.3.0+build.17/tiny-mappings-parser-0.3.0+build.17.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/net/fabricmc/sponge-mixin/0.12.5+mixin.0.8.5/sponge-mixin-0.12.5+mixin.0.8.5.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/net/fabricmc/tiny-remapper/0.8.2/tiny-remapper-0.8.2.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/net/fabricmc/access-widener/2.1.0/access-widener-2.1.0.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/ow2/asm/asm/9.5/asm-9.5.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/ow2/asm/asm-analysis/9.5/asm-analysis-9.5.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/ow2/asm/asm-commons/9.5/asm-commons-9.5.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/ow2/asm/asm-tree/9.5/asm-tree-9.5.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/ow2/asm/asm-util/9.5/asm-util-9.5.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/net/fabricmc/fabric-loader/0.14.22/fabric-loader-0.14.22.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/mojang/minecraft/1.18.2/minecraft-1.18.2-client.jar

Native libraries:
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl-glfw/3.2.2/lwjgl-glfw-3.2.2-natives-windows.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl-jemalloc/3.2.2/lwjgl-jemalloc-3.2.2-natives-windows.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl-openal/3.2.2/lwjgl-openal-3.2.2-natives-windows.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl-opengl/3.2.2/lwjgl-opengl-3.2.2-natives-windows.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl-stb/3.2.2/lwjgl-stb-3.2.2-natives-windows.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl/3.2.2/lwjgl-3.2.2-natives-windows.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/org/lwjgl/lwjgl-tinyfd/3.2.2/lwjgl-tinyfd-3.2.2-natives-windows.jar
C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/com/mojang/text2speech/1.12.4/text2speech-1.12.4-natives-windows.jar

Mods:
[✔] fabric-api-0.76.0+1.18.2
[✔] supershulkers-0.3.2

Params:
--username --version 1.18.2 --gameDir C:/Users/skywa/AppData/Roaming/PrismLauncher/instances/1.18.2/.minecraft --assetsDir C:/Users/skywa/AppData/Roaming/PrismLauncher/assets --assetIndex 1.18 --uuid --accessToken --userType --versionType release

Window size: 1920 x 1080

Launcher: standard

Java Arguments:
[-XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump, -Xms512m, -Xmx4096m, -Duser.language=en]

Minecraft process ID: 33872

[18:23:34] [main/INFO]: Loading Minecraft 1.18.2 with Fabric Loader 0.14.22
[18:23:34] [main/INFO]: Loading 52 mods:
- fabric-api 0.76.0+1.18.2
|-- fabric-api-base 0.4.5+64b7c69360
|-- fabric-api-lookup-api-v1 1.6.3+2373a54560
|-- fabric-biome-api-v1 8.0.7+e83becad60
|-- fabric-block-api-v1 1.0.0+ee3621fc60
|-- fabric-blockrenderlayer-v1 1.1.13+3ac43d9560
|-- fabric-command-api-v1 1.1.10+d7c144a860
|-- fabric-commands-v0 0.2.9+b4f4f6cd60
|-- fabric-containers-v0 0.1.24+d7c144a860
|-- fabric-content-registries-v0 3.1.3+c85f2e3860
|-- fabric-convention-tags-v1 1.1.0+43ce63a460
|-- fabric-crash-report-info-v1 0.2.1+ee261a3e60
|-- fabric-data-generation-api-v1 3.1.0+6c70b68e60
|-- fabric-dimensions-v1 2.1.21+489d6f8260
|-- fabric-entity-events-v1 1.4.9+d7c144a860
|-- fabric-events-interaction-v0 0.4.20+d7c144a860
|-- fabric-events-lifecycle-v0 0.2.22+d7c144a860
|-- fabric-game-rule-api-v1 1.0.13+d7c144a860
|-- fabric-item-api-v1 1.6.2+8165403660
|-- fabric-item-groups-v0 0.3.16+91896a4960
|-- fabric-key-binding-api-v1 1.0.12+54e5b2ec60
|-- fabric-keybindings-v0 0.2.10+b4f4f6cd60
|-- fabric-lifecycle-events-v1 2.1.1+cc71601c60
|-- fabric-loot-api-v2 1.1.2+1997ad1260
|-- fabric-loot-tables-v1 1.1.4+e747827960
|-- fabric-mining-level-api-v1 2.1.6+cc71601c60
|-- fabric-models-v0 0.3.7+d7c144a860
|-- fabric-networking-api-v1 1.0.24+2d30af4b60
|-- fabric-networking-v0 0.3.11+b4f4f6cd60
|-- fabric-object-builder-api-v1 2.1.5+032c981d60
|-- fabric-particles-v1 0.2.13+526dc1ac60
|-- fabric-registry-sync-v0 0.9.12+bb2e047760
|-- fabric-renderer-api-v1 0.5.0+bf48649860
|-- fabric-renderer-indigo 0.6.1+03e2b68760
|-- fabric-renderer-registries-v1 3.2.12+b4f4f6cd60
|-- fabric-rendering-data-attachment-v1 0.3.9+ee3621fc60
|-- fabric-rendering-fluids-v1 2.0.3+54e5b2ec60
|-- fabric-rendering-v0 1.1.14+b4f4f6cd60
|-- fabric-rendering-v1 1.10.8+54e5b2ec60
|-- fabric-resource-conditions-api-v1 2.0.3+91b7aa6660
|-- fabric-resource-loader-v0 0.5.3+047a5ecb60
|-- fabric-screen-api-v1 1.0.11+d882b91560
|-- fabric-screen-handler-api-v1 1.2.3+1f6558e860
|-- fabric-textures-v0 1.0.13+3ac43d9560
|-- fabric-transfer-api-v1 1.6.4+f4563ac860
-- fabric-transitive-access-wideners-v1 1.1.0+e747827960
- fabricloader 0.14.22
- java 17
- minecraft 1.18.2
- supershulkers 0.3.2
|-- carpet 1.4.69
-- mm 2.3
[18:23:34] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=file:/C:/Users/skywa/AppData/Roaming/PrismLauncher/libraries/net/fabricmc/sponge-mixin/0.12.5+mixin.0.8.5/sponge-mixin-0.12.5+mixin.0.8.5.jar Service=Knot/Fabric Env=CLIENT
[18:23:35] [main/INFO]: Compatibility level set to JAVA_16
[18:23:35] [main/INFO]: Compatibility level set to JAVA_17
[18:23:43] [main/ERROR]: Minecraft has crashed!
net.fabricmc.loader.impl.FormattedException: java.lang.IncompatibleClassChangeError: class net.minecraft.class_1886$15 cannot inherit from sealed class net.minecraft.class_1886
at net.fabricmc.loader.impl.FormattedException.ofLocalized(FormattedException.java:63) ~[fabric-loader-0.14.22.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) ~[fabric-loader-0.14.22.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.14.22.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.14.22.jar:?]
at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88) [NewLaunch.jar:?]
at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126) [NewLaunch.jar:?]
at org.prismlauncher.EntryPoint.main(EntryPoint.java:71) [NewLaunch.jar:?]
Caused by: java.lang.IncompatibleClassChangeError: class net.minecraft.class_1886$15 cannot inherit from sealed class net.minecraft.class_1886
at java.lang.ClassLoader.defineClass1(Native Method) ~[?:?]
at java.lang.ClassLoader.defineClass(ClassLoader.java:1012) ~[?:?]
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150) ~[?:?]
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.defineClassFwd(KnotClassLoader.java:153) ~[fabric-loader-0.14.22.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:355) ~[fabric-loader-0.14.22.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) ~[fabric-loader-0.14.22.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:112) ~[fabric-loader-0.14.22.jar:?]
at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
at net.minecraft.class_1900.(class_1900.java:36) ~[client-intermediary.jar:?]
at net.minecraft.class_1893.(class_1893.java:15) ~[client-intermediary.jar:?]
at net.minecraft.class_2378.method_10243(class_2378.java:190) ~[client-intermediary.jar:?]
at net.minecraft.class_2378.method_40280(class_2378.java:352) ~[client-intermediary.jar:?]
at net.minecraft.class_2378.method_34031(class_2378.java:300) ~[client-intermediary.jar:?]
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:721) ~[?:?]
at net.minecraft.class_2378.(class_2378.java:299) ~[client-intermediary.jar:?]
at net.minecraft.class_2966.method_12851(class_2966.java:49) ~[client-intermediary.jar:?]
at net.minecraft.client.main.Main.main(Main.java:153) ~[minecraft-1.18.2-client.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468) ~[fabric-loader-0.14.22.jar:?]
... 5 more
Process exited with code 1.
Clipboard copy at: 09 Oct 2023 18:24:09 -0500

@Skywalker8510
Copy link
Author

i believe the problem has to do with the src\main\java\is\rmob\supershulkers\mixin\EnchantmentTargetMixin.java file but don't know what it means

@Skywalker8510
Copy link
Author

@rmobis can you take a look at this to see if you can figure out what's causing the error?

@rmobis
Copy link
Owner

rmobis commented Nov 2, 2023

Sorry for the late reply here, I haven't been very active with Minecraft lately. Unfortunately I won't be able to help much as developing this plugin was (and still is) a very trial and error workflow and I no longer have my environment setup for developing MC mods. Either way, I can provide some pointers:

At the end of the day, the error you're getting is java.lang.IncompatibleClassChangeError: class net.minecraft.class_1886$15 cannot inherit from sealed class net.minecraft.class_1886. Class net.minecraft.class_1886 is the EnchantmentTarget enum. I did some googling and apparently the culprit is fabric-asm, which is the library that enables part of the hacks we do on the mod. There is an issue open where it describes the issue as being caused by the library not being properly updated to work with Java 17. It links to another issue in another mod where they were apparently able to workaround the issue by using an access widener to remove the sealed property from the class. That's where I would look first.

@Skywalker8510
Copy link
Author

thanks a lot for the help ill take a look at that stuff

@Skywalker8510 Skywalker8510 marked this pull request as ready for review November 6, 2023 05:46
@Skywalker8510
Copy link
Author

@rmobis This is ready to be merged as far as I know.

@RubixDev
Copy link

Just so you know, for 1.18.2 and later there is EnchantedShulkers with very similar functionality.

@Skywalker8510
Copy link
Author

i didn't know about that thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants