-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for smsapi.pl service backend #19
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @twkrol for your contribution!
Would you be able to add tests and documentation for the newly added SMS backend? You can take the tests of the Twilio backend as an example, see:
Line 216 in 0127d6c
class TwilioBackendTests(BaseSmsBackendTests, SimpleTestCase): |
Please let me know if you need any help!
Ok, how to run the test locally? |
After installing all dependencies you should be able to execute the tests using the |
ready to go: documented & tested :) |
Not elegant at the moment, but I need to get the results of sms sending.
Added a dirty thing: sending results, which I need to get after sms was sent (there is provider id of the message, status, etc)
It works in real world, but the tests got it properly as error: there is no property of Message that could be set.
There are options:
|
What if we add to the Message class a property called, say: 'raw_results' |
New backend service: smsapi.pl (Polish SMS gateway service)