Highlighting hint w shortcuts not work in page embed state

[JimmyLv]

Roam.Research-Roam.Research.-.Page.Embed-001852-20220427.mp4

for example:

#Tag {{[[embed]]: [[Test Hello World!]]}}

In this scenario, w is not in effect and cannot open the embed [[Test Hello World!]] page title

[JimmyLv]

is it related here? https://github.com/roam-unofficial/roam-toolkit/blob/770bc52395/src/ts/core/common/mouse.ts#L19

[Stvad]

can confirm/reproduce. it seems to be related to how the html for that case is structured (span inside a), so the hint gets attached to the wrong element

[JimmyLv]

@Stvad wow, great! Is it easy to fix? I'm also more than happy to help if needed! I would love this fix, 😁

[Stvad]

Not sure, I think the fix would be to see if the elements found have sub-element that are links here

roam-toolkit/src/ts/core/features/vim-mode/hint-view.ts

Line 51 in 770bc52

export const updateVimHints = (block: HTMLElement) => {

And attach the class to those instead, but I’m not sure if that’d produce the desired behavior reliably. Contributions are welcome!

[JimmyLv]

ok, but how can I access and click these sub-elements (span inside a)? do you mean the click() method would dispatch the event by the attached classes here?

[JimmyLv]

Does that mean these classes roam-toolkit--hint roam-toolkit--hint1 should be attached to the span element?

[JimmyLv]

Hey @Stvad , I just created the PR and deployed it to vercel, but it doesn't look like there is a roam/js version? https://roam-toolkit.vercel.app/no_preview_spatial.js

[Stvad]

Apologies, I missed this! roam/js version is built off the separate branch atm (roam-js see #164 )

[JimmyLv]

wow, thanks a lot! I just deployed and my PR seems to work well. https://roam-toolkit.vercel.app/entry.js