feat: multipart support

[charlieforward9]

Tried to acknowledge the contributions of the previous contributors to for getting multipart geometries working. Closes #42 and #66 and #158

Co-authored-by: Kanahiro Iguchi [email protected] @Kanahiro
Co-authored-by: Liam O'flynn [email protected] @quorth0n

Includes Prettier formatting

[charlieforward9]

@robertleeplummerjr I tested this using the Antarctica.geojson file and it seems to render "good enough" for now. A strange overlap issue could be addressed down the road, when someones use case requires it. Can be merged. I will be depending on this PR branch till then.

Also willing to take responsibility for managing this repo if you find yourself too busy. Add me as a contributor if you'd like a teammate in this. (Still highly undereducated in the GL space, but managing repos/package releases is pretty straightforward)

[trafficonese]

Thats awesome, thanks! Did you also test out Multi-Linestrings?

[charlieforward9]

@trafficonese I did not. I only needed multipolygon for my use case.

[charlieforward9]

@robertleeplummerjr this should be ready to merge and all related issues/pr's can be closed.

Just a reminder there are some stragler issues to close from my previous PR, see this comment

Finally, publishing the newest release on Github should close #154

[charlieforward9]

@robert-lore @robertleeplummerjr thank you for the merge. Do you plan to make a release and close the resolved issues? I can help you manage this repo if you find yourself without time.

[robert-lore]

I'm installing it on my mac and was having trouble.

[charlieforward9]

@robert-lore Were they from my contributions or your machine?

[arvii]

@charlieforward9 does your fix support combination of Polygon and MultiPolygon on a FeatureCollection? 🙇

[robert-lore]

Just removed canvas, which was causing my install issue, and published.

[charlieforward9]

@charlieforward9 does your fix support combination of Polygon and MultiPolygon on a FeatureCollection? 🙇

Worth taking a look and letting me know. I just took the contributions of @quorth0n and @Kanahiro and applied them to the latest branch, so please let me know if you have any issues.

[charlieforward9]

Just removed canvas, which was causing my install issue, and published.

@robert-lore Great, thank you! I am having trouble running my test suite because of an improperly defined layer.canvas issue. I am going to spend the rest of the day looking into this. If you have any pointers for how to get around this, please share them in #110

[trafficonese]

@charlieforward9 does your fix support combination of Polygon and MultiPolygon on a FeatureCollection? 🙇

@arvii , yes it works also for a combination of polygons and multipolygons.

[arvii]

@charlieforward9 does your fix support combination of Polygon and MultiPolygon on a FeatureCollection? 🙇

@arvii , yes it works also for a combination of polygons and multipolygons.

Hi @trafficonese Thank you so much for checking also. Could you please send me the sample data you tested? I want to verify if my format is correct. I tested it with a combination of Polygon and MultiPolygon in a GeoJSON FeatureCollection, but only the Polygon rendered. When I tested a GeoJSON Feature with a single MultiPolygon, it rendered correctly. Thank you so much! 🙇

[trafficonese]

@arvii It's a very simple Featurecollection:

const data: FeatureCollection<Geometry> = {
  type: "FeatureCollection",
  features: [
    {
      type: "Feature",
      properties: { name: "Polygon 1" },
      geometry: {
        type: "Polygon",
        coordinates: [
          [
            [102.0, 0.0],
            [103.0, 0.0],
            [103.0, 1.0],
            [102.0, 1.0],
            [102.0, 0.0],
          ],
        ],
      },
    },
    {
      type: "Feature",
      properties: { name: "MultiPolygon 1" },
      geometry: {
        type: "MultiPolygon",
        coordinates: [
          [
            [
              [100.0, 0.0],
              [101.0, 0.0],
              [101.0, 1.0],
              [100.0, 1.0],
              [100.0, 0.0],
            ],
          ],
          [
            [
              [100.2, 0.2],
              [100.8, 0.2],
              [100.8, 0.8],
              [100.2, 0.8],
              [100.2, 0.2],
            ],
          ],
        ],
      },
    },
    {
      type: "Feature",
      properties: { name: "Polygon 2" },
      geometry: {
        type: "Polygon",
        coordinates: [
          [
            [104.0, 0.0],
            [105.0, 0.0],
            [105.0, 1.0],
            [104.0, 1.0],
            [104.0, 0.0],
          ],
        ],
      },
    },
    {
      type: "Feature",
      properties: { name: "MultiPolygon 2" },
      geometry: {
        type: "MultiPolygon",
        coordinates: [
          [
            [
              [102.0, 2.0],
              [103.0, 2.0],
              [103.0, 3.0],
              [102.0, 3.0],
              [102.0, 2.0],
            ],
          ],
          [
            [
              [102.2, 2.2],
              [102.8, 2.2],
              [102.8, 2.8],
              [102.2, 2.8],
              [102.2, 2.2],
            ],
          ],
        ],
      },
    },
  ],
};