ISSUE-1: Started implementing UI to configure replacements #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anotherjames Made a lot of progress. UI almost ready to use. Still have to implement the "Empty table" option. |
| @@ -83,10 +72,9 @@ public static function getInstance($dbSpec, $options, EventDispatcherInterface $ | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| // @TODO Combine with above dispatched event to allow changing empty tables? | |
| if (!empty($config['empty_tables'])) { | |
| $empty_tables = array_keys(array_filter($config['empty_tables'])); | |
| $options['structure-tables-list'] = $empty_tables; | |
| } | |
I could be very wrong - as this is totally untested! - but I suspect this might be do the trick to implementing empty tables, as asked in #1 (comment) ?
As mentioned in the @TODO comment though, it should probably be 'alterable' - maybe the GdprReplacementsEvent could expanded to cover more than just replacements, so that both settings could be extended by modules looking to add their own tables?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.