Remove TypeScript #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Thanks to https://github.com/futurGH/ts-to-jsdoc, easy to use via it CLI and npx!) |
|
CI is a bit rusty after 2 years. Looking into it. |
Deploying brut with
|
| Latest commit: |
8101163
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ade448a.brut.pages.dev |
| Branch Preview URL: | https://vanilla.brut.pages.dev |
I forgot to build the site before starting the dev server and somehow serve still responded with a 200, so playwright just timed out
robinmetral
added a commit
that referenced
this pull request
Aug 9, 2024
Even after #29, this is still helpful when working with checkJs: true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
Note: the bulk of the (huge) diff is lockfile changes. I had to update all testing dependencies for the CI to pass again (it had been two years it hadn't run and Playwright was hanging in GitHub Actions). A simple deps update made tests pass as expected.