Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable yourdfpy unit tests #51

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Re-enable yourdfpy unit tests #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33f9bb8
Re-enable yourdfpy unit tests
stephane-caron Jan 8, 2024
9803295
Bump yourdfpy version to v0.0.56
stephane-caron Jan 24, 2024
023c671
Update the changelog
stephane-caron Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ All notable changes to this project will be documented in this file.
- Description: UNITREE Z1 (thanks to @lvjonok)
- Description: Skydio X2 (thanks to @lvjonok)

### Changed

- Bump yourdfpy minimum version to 0.0.56

### Fixed

- Path to UNITREE H1 (thanks to @lvjonok)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ opts = [
"pin >=2.6.10",
"idyntree >= 8.0.0",
"robomeshcat >=1.0.4",
"yourdfpy >=0.0.53",
"yourdfpy >=0.0.56",
]

[project.scripts]
Expand Down
25 changes: 10 additions & 15 deletions tests/test_loaders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,9 @@
from robot_descriptions.loaders.robomeshcat import (
load_robot_description as load_robomeshcat,
)

# Disabled because of https://github.com/clemense/yourdfpy/issues/49
# See https://github.com/robot-descriptions/robot_descriptions.py/issues/43
# from robot_descriptions.loaders.yourdfpy import (
# load_robot_description as load_yourdfpy,
# )
from robot_descriptions.loaders.yourdfpy import (
load_robot_description as load_yourdfpy,
)


class TestLoaders(unittest.TestCase):
Expand Down Expand Up @@ -68,15 +65,13 @@ def test_robomeshcat(self):
)
)

# Disabled because of https://github.com/clemense/yourdfpy/issues/49
# See https://github.com/robot-descriptions/robot_descriptions.py/issues/43
# def test_yourdfpy(self):
# self.assertIsNotNone(
# load_yourdfpy(
# "upkie_description",
# commit=self.upkie_description_commit,
# )
# )
def test_yourdfpy(self):
self.assertIsNotNone(
load_yourdfpy(
"upkie_description",
commit=self.upkie_description_commit,
)
)

def test_idyntree(self):
self.assertIsNotNone(
Expand Down
6 changes: 3 additions & 3 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ deps =
pin >=2.6.14
pybullet >=3.2.5
robomeshcat >= 1.0.4
yourdfpy >=0.0.53
yourdfpy >=0.0.56
commands =
coverage erase
coverage run -m unittest tests
Expand All @@ -36,7 +36,7 @@ deps =
pylint
robomeshcat >= 1.0.4
ruff >=0.0.220
yourdfpy >=0.0.53
yourdfpy >=0.0.56
commands =
black --check --diff robot_descriptions
ruff robot_descriptions
Expand Down Expand Up @@ -86,7 +86,7 @@ deps =
lxml <=4.9.4
numpy >=1.23.4
trimesh ~=3.16.0
yourdfpy >=0.0.53
yourdfpy >=0.0.56
commands =
python -m unittest test_yourdfpy.py

Expand Down