Feature/temperature reading #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @valegagge |
valegagge
requested changes
Dec 1, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
pattacini
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
CI is now passed ✅
@MSECode, please address @valegagge's comments to proceed further.
…mmented unused lines
MSECode
force-pushed
the
feature/temperatureReading
branch
from
7ffade8 to
f39ad6a
Compare
|
It should be now ready for the review |
|
Hi @MSECode, cc @pattacini |
pattacini
approved these changes
Dec 1, 2023
MSECode
added a commit
to valegagge/robots-configuration
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the following changes:
TemperatureSensorTypevalues for all the necessary joints and set it to NONE so that we have back-compatibility and add thehardwareTemperatureLimitsand thewarningTemperatureLimitsand keep them commented for back-compatibility (default suggested values are provided in the commented line in the file)