Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LuGre friction model parameters added #694

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ale-git
Copy link
Contributor

@ale-git ale-git commented Dec 5, 2024

The LuGre friction model parameters have been added to the ergoCub robot configurations.
The template file has been updated as well.

@ale-git ale-git requested a review from pattacini December 5, 2024 10:24
@ale-git ale-git self-assigned this Dec 5, 2024
@pattacini
Copy link
Member

To avoid generating conflicts, I would give priority to merging #692 first,

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed T2T during the review, it'd be better off updating only the templates with the values you used during your test, @ale-git, while removing the commented sections outright.

@pattacini
Copy link
Member

/remind December 16, @ale-git please proceed asap with this.

Copy link

octo-reminder bot commented Dec 14, 2024

Reminder
Monday, December 16, 2024 10:00 AM (GMT+01:00)

, @ale-git please proceed asap with this.

Copy link

octo-reminder bot commented Dec 16, 2024

🔔 @pattacini

, @ale-git please proceed asap with this.

@ale-git
Copy link
Contributor Author

ale-git commented Dec 17, 2024

@pattacini I've removed the LUGRE sections (apart from template).

@pattacini
Copy link
Member

We're almost there but this PR is not really spot on yet.
Can you please give me push access to your fork?

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@pattacini pattacini merged commit cb0f5ee into robotology:devel Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants