Adding functions to compute the visual width of east asian characters #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewilliamboswell
requested changes
Jun 24, 2024
|
Thank you for your review! I added a commit in which I incorporated the functions for getting the EAW property and the width of code points into the CodePoint module, but I'm not sure if that is the way to do it. I have also added some tests to both the generated module and it's generator. |
lukewilliamboswell
force-pushed
the
east-asian-width-gen
branch
from
eabc5df
to
369f5f2
Compare
lukewilliamboswell
approved these changes
Jun 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement function to compute the East Asian Width Property of codepoints as decribed in issue 6.
I am new not only to roc but to functional programming in general, so I expect this code to be unidiomatic. I am open to criticism and to fix any issues.
The results of the function have been tested against other open source libraries.