Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable arm64 build for rocker/rstudio after RStudio IDE 2023.05.0 #651

Merged
merged 5 commits into from
May 17, 2023
+10 −3
Merged

enable arm64 build for rocker/rstudio after RStudio IDE 2023.05.0 #651

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
52b13cb
enable arm64 build for rocker/rstudio after RStudio IDE 2023.05.1
eitsupi May 13, 2023
9688668
refactor: purrr::cross -> tidyr::expand_grid
eitsupi May 13, 2023
d23255e
add comments about hard coded RStudio version
eitsupi May 13, 2023
496874b
change the version
eitsupi May 16, 2023
9338c3c
change the version
eitsupi May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions build/make-stacks.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,12 @@ library(gert)
NULL
}

urls_try <- list(
urls_try <- tidyr::expand_grid(
date = dates_try,
distro_version_name = c(distro_version_name, fallback_distro),
type = c("binary")
) |>
purrr::cross() |>
purrr::map_chr(purrr::lift(.make_rspm_cran_url_linux)) |>
purrr::pmap_chr(.make_rspm_cran_url_linux) |>
unique()

for (i in seq_along(urls_try)) {
Expand Down Expand Up @@ -224,6 +223,14 @@ write_stack <- function(r_version,
r_latest
)
template$stack[[2]]$ENV$RSTUDIO_VERSION <- rstudio_version
template$stack[[2]]$platforms <-
# linux/arm64 platform version of RStudio IDE will bundle Quarto CLI after version 2023.05.1
eitsupi marked this conversation as resolved.
Show resolved Hide resolved
# (https://github.com/rstudio/rstudio/issues/12411)
# We are postponing the build of the linux/arm64 version of rocker/rstudio until this version
# because we want to fix the version of Quarto CLI included in rocker/rstudio
if (numeric_version(stringr::str_replace_all(rstudio_version, r"(\+)", ".")) > "2023.05.0") {
list("linux/amd64", "linux/arm64")
}

# rocker/tidyverse
template$stack[[3]]$FROM <- stringr::str_c("rocker/rstudio:", r_version)
Expand Down