Implement pdao status and signalling address commands #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add RocketSignerRegistry to ServiceProvider
jshufro
suggested changes
Jul 17, 2024
rocketpool-daemon/api/pdao/status.go
Outdated
| @@ -135,7 +135,8 @@ func (c *protocolDaoGetStatusContext) PrepareData(data *api.ProtocolDAOStatusRes | |||
|
|
|||
| data.BlockNumber = uint32(c.blockNumber) | |||
| data.IsNodeRegistered = c.isNodeRegistered | |||
| // data.SignallingAddress = c.signallingAddress | |||
| data.SignallingAddress = c.signallingAddress | |||
| data.SignallingAddressFormatted = utils.GetFormattedAddress(c.ec, data.SignallingAddress) | |||
There was a problem hiding this comment.
we should probably rename this to "GetPrimaryENS" or something.
We need to rethink our whole approach to ens, though, so it's a job for later: #583 (comment)
jshufro
suggested changes
Jul 18, 2024
Remove const, fix message and nil pointer
thomaspanf
force-pushed
the
implement-pdao-status
branch
from
9b638f7 to
32a7c96
Compare
|
Snapshot isn't on holesky and I don't have a mainnet node so one of you guys should let me know if this works properly. That'd be much appreciated. It should look something like this: |
|
Should We can close NMC#17 if this looks good, since all the EIP712 related logic resides in the smartnode now. |
jshufro
suggested changes
Jul 19, 2024
jshufro
reviewed
Jul 22, 2024
Co-authored-by: Jacob Shufro <[email protected]>
|
bleep bloop Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
jshufro
suggested changes
Jul 22, 2024
shared/eip712/eip712.go
Outdated
| const EIP712Length = 65 | ||
|
|
||
| // Pretty print for EIP712Components | ||
| func (e EIP712Components) String() { |
There was a problem hiding this comment.
rename this to Print(). Functions named String() should return a string to fulfill https://pkg.go.dev/fmt#Stringer
however, i think we want the Stringer interface to be implemented as:
func (e EIP712Components) String() string {
out, err := e.MarshalText()
if err != nil {
// MarshalText should never return an error
panic(err)
}
return string(out)
}so that the "native" format is the 65 byte 0x-prefixed hex string.
jshufro
approved these changes
Jul 23, 2024
jshufro
suggested changes
Jul 23, 2024
jshufro
suggested changes
Jul 23, 2024
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
jshufro
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rocketpool pdao statusrocketpool pdao set-signalling-addressrocketpool pdao clear-signalling-address