New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip request when there are no validators #693

Merged

0xfornax merged 1 commit into master from v1-fix-error-no-validators

Oct 30, 2024

+4 −0

Member

0xfornax commented Oct 29, 2024

Skips the validator duties query when there are no validators running.
Closes #690

jshufro reviewed

View reviewed changes

shared/services/beacon/client/std-http-client.go Outdated Show resolved Hide resolved

jshufro approved these changes

View reviewed changes

Contributor

jshufro left a comment

Looks like both places that call the function simply iterate over it with for which is nil-safe.


          Skip request when there are no validators

55b74d7

0xfornax force-pushed the v1-fix-error-no-validators branch from e264be5 to 55b74d7 Compare

October 30, 2024 01:24

0xfornax merged commit 54629df into master

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet