Jasper #2
Jasper #2
Conversation
merged static yml
…m SVG to html webcomponent
| @@ -1,51 +1,71 @@ | |||
| import { useState, useEffect } from "react"; | |||
There was a problem hiding this comment.
I prefer browserRouter implementations over hash routers, we discussed how you can fix this in the morning standup sessions
| function App() { | ||
| const [messages, setMessages] = useState([]); | ||
| export default function App() { | ||
| //check login status |
There was a problem hiding this comment.
Nice work lifting up the required states for the application to run smoothly
| let messageListItems = messages.map((message) => ( | ||
| <li key={message.key}>{message.val}</li> | ||
| )); | ||
| const router = createHashRouter([ |
There was a problem hiding this comment.
You could use nested Routing along with an outlet to reduce the number of times you load and reload the navbar
| @@ -0,0 +1,92 @@ | |||
| import { useState } from "react"; | |||
There was a problem hiding this comment.
Nice work keeping all auth logic in one component and either showing the form to login or the button ton sign out, really smart UI and UX thought!
| @@ -1,6 +1,10 @@ | |||
| import React from "react"; | |||
| import ReactDOM from "react-dom/client"; | |||
There was a problem hiding this comment.
Can remove strict mode!
| @@ -1,21 +1,27 @@ | |||
| // Import the functions you need from the SDKs you need | |||
There was a problem hiding this comment.
Get conventional setup here!
|
|
||
| const messagesRef = databaseRef(database, DB_MESSAGES_KEY); | ||
|
|
||
| const writeData = async () => { |
There was a problem hiding this comment.
Nice implementation of async and await code!
|
|
||
| return ( | ||
| <form onSubmit={(e) => (e.preventDefault(), e.target.reset())}> | ||
| <input |
There was a problem hiding this comment.
Use some stylesheets to reduce repeated code
| url = await getDownloadURL(newStorageRef); | ||
| name = file.name; | ||
| } | ||
| set(push(messagesRef), { |
There was a problem hiding this comment.
Great implementation of likes to ensure that users can only like once, I also like that you have a like Count such that you dont need to process firebase data every load.
| @@ -0,0 +1,167 @@ | |||
| import { useEffect, useState } from "react"; | |||
There was a problem hiding this comment.
Great structure and logic implemented here! Superb work
No description provided.