Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rails 8 #151

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Support Rails 8 #151

merged 1 commit into from
Nov 12, 2024

Conversation

kmcphillips
Copy link
Contributor

Specifying a < 8 for actionpack(rails) means that this gem is incompatible with Rails 8 for now.

The real problem here is that 0.7.0 had no dependency versions defined so any app attempting to upgrade without specifying a min version of this gem will get downgraded to 0.7.0:
https://github.com/roidrage/redis-session-store/blob/v0.7.0/redis-session-store.gemspec#L21

That causes this exception for us at runtime:

/redis-session-store-0.7.0/lib/redis-session-store.rb:10:in `<class:RedisSessionStore>': uninitialized constant Rack::Session::Abstract::ENV_SESSION_OPTIONS_KEY (NameError)

    ENV_SESSION_OPTIONS_KEY = Rack::Session::Abstract::ENV_SESSION_OPTIONS_KEY

This was similarly encountered for Rails 6 in #110

@kmcphillips
Copy link
Contributor Author

Ping @Jesterovskiy

@Jesterovskiy
Copy link
Collaborator

Thanks for your contribution! Right now, I don't have time to support this repo at all =(

@Jesterovskiy Jesterovskiy merged commit 6b4e319 into roidrage:master Nov 12, 2024
8 checks passed
@kmcphillips
Copy link
Contributor Author

That's ok. @Jesterovskiy, it's pretty legacy anyway. I think you can just use the built in ActionDispatch::Session::CacheStore with a redis cache and get nearly the same thing.

I'm just trying to minimally unblock people who already depend on it.

I'll open a PR with the version bump, then can you just release it?

@kmcphillips
Copy link
Contributor Author

#152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants