Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Race conditions handling #95

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rtrv
Copy link

@rtrv rtrv commented Aug 29, 2017

Just a concept for #94, I want to discuss it. Current solution is following:

  • Some action gets a session and also gets it as 'initial_session_state'
  • When it sets the session back, it compares its initial state with current session state
  • If there is any difference, session data from parameters will be merged with current session state

Current action data have higher priority in this case. I think, if everybody has no problems with this concept, we could discuss of tests or another methods structure maybe.

This behaviour is optional by ':handle_race_conditions' boolean key in configuration.

@rtrv rtrv force-pushed the handle_race_conditions branch 5 times, most recently from 5b06e25 to 64235c2 Compare September 4, 2017 10:01
@rtrv rtrv force-pushed the handle_race_conditions branch from 64235c2 to 3928b8f Compare September 4, 2017 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant